RFR (S) JDK-8160487: JVM Should Check If java.lang.reflect.Module is a Final Class Not a Subclass

[Lois Foltan]

On 7/27/2016 1:54 PM, Claes Redestad wrote:
> Hello,
>
> On 07/27/2016 07:41 PM, Lois Foltan wrote:
>> Hello,
>>
>> Please review the following fix:
>>
>> Webrev:
>>     http://cr.openjdk.java.net/~lfoltan/bug_jdk8160487/webrev/
>
> looks good to me!

Thanks for  the review!

>
>>
>> Bug: JVM Should Check If java.lang.reflect.Module is a Final Class 
>> Not a Subclass
>>     https://bugs.openjdk.java.net/browse/JDK-8160487
>>
>> Summary:
>> java.lang.reflect.Module is defined as a final class [1].  The VM was 
>> incorrectly checking for a subclass of java.lang.reflect.Module to 
>> validate a module.
>
> Nit: The bug title strikes me as a bit weird, as it seems to imply 
> it's about JVM checking that java.lang.reflect.Module is a final 
> class, which is not what this fix is about.

I agree, improved on the wording and changed to "JVM should validate a 
module by checking for an instance of java.lang.reflect.Module"

Thanks,
Lois

>
> /Claes
>
>>
>> Testing:
>> Ran full hotspot nightly testing tests, JCK vm & lang
>>
>> Thanks,
>> Lois
>>
>> [1] http://download.java.net/java/jigsaw/docs/api/index.html
>