RFR (S) JDK-8160487: JVM Should Check If java.lang.reflect.Module is a Final Class Not a Subclass

[Coleen Phillimore]

On 7/27/16 2:37 PM, Lois Foltan wrote:
>
> On 7/27/2016 2:31 PM, Coleen Phillimore wrote:
>>
>> This change looks good, but is there a test for it?
>
> Thanks for the review.  The test is at 
> hotspot/test/runtime/modules/JVMDefineModule.java

Oh yeah, okay, I reviewed the test too....  just blurred with the rest.

Coleen

> Lois
>
>> thanks,
>> Coleen
>>
>> On 7/27/16 1:41 PM, Lois Foltan wrote:
>>> Hello,
>>>
>>> Please review the following fix:
>>>
>>> Webrev:
>>>     http://cr.openjdk.java.net/~lfoltan/bug_jdk8160487/webrev/
>>>
>>> Bug: JVM Should Check If java.lang.reflect.Module is a Final Class 
>>> Not a Subclass
>>>     https://bugs.openjdk.java.net/browse/JDK-8160487
>>>
>>> Summary:
>>> java.lang.reflect.Module is defined as a final class [1].  The VM 
>>> was incorrectly checking for a subclass of java.lang.reflect.Module 
>>> to validate a module.
>>>
>>> Testing:
>>> Ran full hotspot nightly testing tests, JCK vm & lang
>>>
>>> Thanks,
>>> Lois
>>>
>>> [1] http://download.java.net/java/jigsaw/docs/api/index.html
>>
>