RFR(XS) 8158060: BasicLayerTest causes fatal error: Thread holding lock at safepoint that vm can block on: Module_lock

[harold seigel]

Thanks David!

Harold


On 6/1/2016 12:02 AM, David Holmes wrote:
> On 31/05/2016 11:59 PM, harold seigel wrote:
>> Hi David,
>>
>> Thanks for the review.  We could acquire the Module_lock if a
>> VMOperation caused a gc that resulted in a class loader going away.
>
> OK.
>
>> How does that impact this fix for 8158060?
>
> Simply wondering when we avoid throwing exceptions with locks held, 
> and when we add locks to the list of locks that can be held at a 
> safepoint. But forget I asked :)
>
> Cheers,
> David
>
>> Thanks, Harold
>>
>>
>> On 5/30/2016 7:43 PM, David Holmes wrote:
>>> Hi Harold,
>>>
>>> On 31/05/2016 3:09 AM, harold seigel wrote:
>>>> Hi,
>>>>
>>>> Please review this small change to fix bug 8158060.  The fix moves the
>>>> exception throw to outside of the block containing the module lock.
>>>>
>>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8158060
>>>>
>>>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8158060/
>>>
>>> Fix looks good.
>>>
>>> Though I'm wondering - do we ever actually acquire the Module_lock as
>>> part of a VMOperation? (I know we are very conservative with this :) ).
>>>
>>> Thanks,
>>> David
>>>
>>>> The fix was tested with an RBT nightly test run and with the failing
>>>> test.
>>>>
>>>> Thanks, Harold
>>>>
>>