RFR (XS): 8074085: os::get_native_stack() could use some cleanup

[Всеволод Толстопятов]

Thank you, so what should I do? Should I wait for new forests and then
return to this review or give it up and take another CR?

--
Best regards,
Tolstopyatov Vsevolod

On Tue, May 31, 2016 at 3:47 PM, David Holmes <david.holmes at oracle.com>
wrote:

> On 31/05/2016 9:42 PM, Всеволод Толстопятов wrote:
>
>>
>> On Tue, May 31, 2016 at 1:29 PM, David Holmes <david.holmes at oracle.com
>> <mailto:david.holmes at oracle.com>> wrote:
>>
>>>
>>> We don't have different "branches" in OpenJDK. So all enhancements
>>>
>> must now go through an approval process.
>>
>>>
>>> Also I just noticed you did this against the hs-rt hotspot repo - that
>>>
>> forest is no longer used, you need to use jdk9/hs in its place.
>>
>>
>> Got it. Which forest should I pick to get this change into 10 (as CR
>> states) instead of 9? I'm not intended to get it into current release.
>>
>
> There has been no word yet when any forests will upon up for 10.
>
> David
> ------
>
>
> Yes I suspected that was what you were doing but as I said it is hard
>>>
>> to see how to credit you the contribution when the code change is in the
>> bug report already. Never seen this situation before :)
>>
>> There are many [starter] tickets like "remove this unused code/useless
>> branch/irrelevant assertion", so I thought it's applicable. Anyway it's
>> up to you, there are other things I will try to fix :)
>>
>>
>> --
>> Best regards,
>> Tolstopyatov Vsevolod
>>
>>