RFR(xs): 8153876: Replace 4K stack allocations with Resource allocations

David Holmes david.holmes at oracle.com
Fri Jun 3 01:05:57 UTC 2016


Hi Calvin,

On 3/06/2016 9:13 AM, Calvin Cheung wrote:
>
> Please review this small fix for replacing some of the array
> declarations with the resource allocation macros.

If you add a resource allocation don't you also need to ensure there is 
a ResourceMark to clean it up again?

And what is the overhead of using resource allocation versus stack 
allocation? A lot of this seems to be in startup code.

> bug: https://bugs.openjdk.java.net/browse/JDK-8153876
> webrev: http://cr.openjdk.java.net/~ccheung/8153876/webrev.00/

src/share/vm/memory/metaspaceShared.cpp

This change seems unnecessary - we don't have stackoverflow concerns 
when doing a dump.

Thanks,
David

> Testing:
>     JPRT
>     non-colo "quick" tests
>
> thanks,
> Calvin


More information about the hotspot-runtime-dev mailing list