[8u] RFR: JDK-8147451: Crash in Method::checked_resolve_jmethod_id(_jmethodID*)

[Coleen Phillimore]

This seems like a safe change.
Coleen

On 5/24/16 4:34 AM, Shafi Ahmad wrote:
> Hi,
>
>   
>
> Please review the small code change for bug: "JDK-8147451: Crash in Method::checked_resolve_jmethod_id(_jmethodID*)" on jdk8u-dev
>
>   
>
> Summary:
>
> resolve_jmethod_id() is getting called with invalid jmethodID and there is no check for validity of the method id inside this function. So before calling resolve_jmethod_id() we should check its validity.
>
> This code change add this check. Also inside Method::is_method_id() we are not checking return value of method_holder(). It may return NULL if method id is not valid so I have added null check for this too.
>
>   
>
> Webrev: http://cr.openjdk.java.net/~shshahma/8147451/webrev.00/
>
> Jdk8 bug: https://bugs.openjdk.java.net/browse/JDK-8147451
>
>   
>
> Test:  Run jprt
>
>   
>
> Regards,
>
> Shafi
>
>