RFR 8158297: Lack of proper checking of non-well formed elements in CONSTANT_Utf8_info's structure

Coleen Phillimore coleen.phillimore at oracle.com
Tue Jun 7 15:18:00 UTC 2016



On 6/7/16 4:39 AM, serguei.spitsyn at oracle.com wrote:
> Coleen,
>
> A minor comment:
>   The comment at the line 4702 needs a small update:
>      or trailing '/'  => ', leading or trailing '/'

Yes, thanks.  I'd left out leading '/' in the comment.

>   Q1: Does the comment at the line 4675 needs an update too?
How about this updated comment:

// Unqualified names may not contain the characters '.', ';', '[', or '/'.
// In class names, '/' separates unqualified names.  This is verified in 
this function also.

Thanks,
Coleen
>
>
> Otherwise, it looks good to me.
>
> Thanks,
> Serguei
>
> On 6/6/16 15:56, Coleen Phillimore wrote:
>> Summary: Disallow // in class file names during parsing and throw 
>> ClassFormatException
>>
>> Tested with selection resolution and jck tests.
>>
>> bug link https://bugs.openjdk.java.net/browse/JDK-8158297
>> local webrev at 
>> http://oklahoma.us.oracle.com/~cphillim/webrev/8158297.01/webrev
>>
>>
>> Thanks,
>> Coleen
>



More information about the hotspot-runtime-dev mailing list