RFR(S): [testbug] CommitOverlappingRegions.java can not deal with pages > 32K
Lindenmaier, Goetz
goetz.lindenmaier at sap.com
Wed Jun 8 09:27:03 UTC 2016
Hi,
fixed this one, too:
http://cr.openjdk.java.net/~goetz/wr16/8158929-CommitOverlap/webrev.03/
Best regards,
Goetz.
> -----Original Message-----
> From: David Holmes [mailto:david.holmes at oracle.com]
> Sent: Mittwoch, 8. Juni 2016 11:16
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-runtime-
> dev at openjdk.java.net
> Subject: Re: RFR(S): [testbug] CommitOverlappingRegions.java can not deal
> with pages > 32K
>
> Looks good. Just need to update the copyright year:
>
> 2015, -> 2015, 2016,
>
> Thanks,
> David
>
> On 8/06/2016 4:48 PM, Lindenmaier, Goetz wrote:
> > Hi David,
> >
> > thanks for looking at this.
> > I fixed the comments:
> > http://cr.openjdk.java.net/~goetz/wr16/8158929-
> CommitOverlap/webrev.02/
> >
> > I tested this on ppc, linuxx86_64, sun_64 and darwinintel.
> >
> > Best regards,
> > Goetz.
> >
> >> -----Original Message-----
> >> From: David Holmes [mailto:david.holmes at oracle.com]
> >> Sent: Dienstag, 7. Juni 2016 22:31
> >> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-runtime-
> >> dev at openjdk.java.net
> >> Subject: Re: RFR(S): [testbug] CommitOverlappingRegions.java can not
> deal
> >> with pages > 32K
> >>
> >> Hi Goetz,
> >>
> >> On 8/06/2016 12:14 AM, Lindenmaier, Goetz wrote:
> >>> Hi,
> >>>
> >>> On ppc, we often have 64K pages. Commit/uncommit with 32K
> quantities
> >> fails
> >>> If not page aligned.
> >>>
> >>> Fix: increase the granularity of the mapped chunks if the pagesize is >
> 32K.
> >>> The Strings for test result checking must be adapted.
> >>
> >> All these comments also need adjusting:
> >>
> >> // Expected Total: 6 x 32KB = 192KB
> >>
> >> Should now be just
> >>
> >> // Expected Total: 6 x sizek KB
> >>
> >> We need to check this change works on all platforms.
> >>
> >> Thanks,
> >> David
> >>
> >>> Please review this change. I please need a sponsor.
> >>> http://cr.openjdk.java.net/~goetz/wr16/8158929-
> >> CommitOverlap/webrev.01/
> >>>
> >>> Best regards,
> >>> Goetz.
> >>>
More information about the hotspot-runtime-dev
mailing list