RFR 8157592: StackTraceLogging fails with stack overflow on 32-bit Windows

Jiangli Zhou jiangli.zhou at Oracle.COM
Thu Jun 9 21:30:09 UTC 2016


Hi George,

A small formatting issue: the ‘catch (Exception e) {’ at line 65 can be moved up to line 64 after ‘}'. I also have a question. Why not change the ‘catch(Exception e)’ to ‘catch(Throwable e)’, so it doesn’t have to address StackOverflowError separately?

Thanks,
Jiangli

> On Jun 9, 2016, at 11:09 AM, George Triantafillou <george.triantafillou at oracle.com> wrote:
> 
> Please review this small change to fix test failures on 32-bit Windows.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8157592
> Open webrev: http://cr.openjdk.java.net/~gtriantafill/8157592/webrev/ <http://cr.openjdk.java.net/%7Egtriantafill/8157592/webrev/>
> 
> TestThrowable.java: Added catch for intermittent StackOverflowError errors on 32-bit Windows.
> 
> StackTraceLogging.java: Removed unused updateEnvironment method.
> 
> Tested locally on 32-bit Windows as well as RBT.
> 
> -George
> 



More information about the hotspot-runtime-dev mailing list