RFR 8157592: StackTraceLogging fails with stack overflow on 32-bit Windows

David Holmes david.holmes at oracle.com
Fri Jun 10 01:08:04 UTC 2016


Hi George,

On 10/06/2016 4:09 AM, George Triantafillou wrote:
> Please review this small change to fix test failures on 32-bit Windows.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8157592
> Open webrev: http://cr.openjdk.java.net/~gtriantafill/8157592/webrev/
> <http://cr.openjdk.java.net/%7Egtriantafill/8157592/webrev/>
>
> TestThrowable.java: Added catch for intermittent StackOverflowError
> errors on 32-bit Windows.

This does not seem to be addressing the problem - why do we suddenly 
start getting SOE when running this test? I asked that question in the 
bug report. If something has changed to trigger this then we need to 
ensure that change was intended/desirable and then look at how to adjust 
the test - not simply catch the SOE and ignore it.

Thanks,
David
-----


> StackTraceLogging.java: Removed unused updateEnvironment method.
>
> Tested locally on 32-bit Windows as well as RBT.
>
> -George
>


More information about the hotspot-runtime-dev mailing list