RFR(XS): JDK-8159328 [TESTBUG] ProblematicFrameTest.java throws an exception (due to trying to access Unsafe) but still passes

George Triantafillou george.triantafillou at oracle.com
Tue Jun 14 17:58:20 UTC 2016


Hi Dmitry,

Thanks for the review.

On 6/14/2016 10:08 AM, Dmitry Dmitriev wrote:
> Hi George,
>
> Bug report states: "Besides resolving this issue, the test should also 
> be checking to make sure that no exception was thrown by the 
> subprocess so problems like this are detected by the test.". It is 
> possible to add "output.shouldNotContain(...)" to catch such situations?
Updated in place:

http://cr.openjdk.java.net/%7Egtriantafill/8159328/webrev/

-George
>
> Thanks,
> Dmitry
>
> On 14.06.2016 15:39, George Triantafillou wrote:
>> Please review this small change to fix a test failure in 
>> ProblematicFrameTest.java
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8159328
>> Open webrev: http://cr.openjdk.java.net/~gtriantafill/8159328/webrev/ 
>> <http://cr.openjdk.java.net/%7Egtriantafill/8159328/webrev/>
>>
>> Tested locally on Linux.
>>
>> -George
>>
>



More information about the hotspot-runtime-dev mailing list