RFR(S): 8159156: [TESTBUG] ReserveMemory test is not useful on Aix.

David Holmes david.holmes at oracle.com
Tue Jun 14 20:57:44 UTC 2016


Sorry Goetz, this slipped through the cracks.

The updated version looks good.

Thanks,
David

On 15/06/2016 4:58 AM, Lindenmaier, Goetz wrote:
> Hi Coleen,
>
> thanks for sponsoring!
>
> Best regards,
>   Goetz.
>
>> -----Original Message-----
>> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
>> bounces at openjdk.java.net] On Behalf Of Coleen Phillimore
>> Sent: Tuesday, June 14, 2016 6:05 PM
>> To: hotspot-runtime-dev at openjdk.java.net
>> Subject: Re: RFR(S): 8159156: [TESTBUG] ReserveMemory test is not useful
>> on Aix.
>>
>>
>> I'll sponsor it.  Since it's small it only needs David's review so I'll
>> use the patch in the webrev.  It does looks fine to me.
>> thanks,
>> Coleen
>>
>> On 6/14/16 10:06 AM, Lindenmaier, Goetz wrote:
>>> Hi,
>>>
>>> could someone please sponsor this tiny fix?
>>>
>>> Thanks,
>>>    Goetz.
>>>
>>>> -----Original Message-----
>>>> From: Lindenmaier, Goetz
>>>> Sent: Freitag, 10. Juni 2016 10:29
>>>> To: 'David Holmes' <david.holmes at oracle.com>; hotspot-runtime-
>>>> dev at openjdk.java.net
>>>> Subject: RE: RFR(S): 8159156: [TESTBUG] ReserveMemory test is not
>> useful
>>>> on Aix.
>>>>
>>>> Hi David,
>>>>
>>>> you are right, that's much better.
>>>> http://cr.openjdk.java.net/~goetz/wr16/8159156-
>> aixResMemTest/webrev.02/
>>>>
>>>> Best regards,
>>>>    Goetz.
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: David Holmes [mailto:david.holmes at oracle.com]
>>>>> Sent: Freitag, 10. Juni 2016 03:40
>>>>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-
>> runtime-
>>>>> dev at openjdk.java.net
>>>>> Subject: Re: RFR(S): 8159156: [TESTBUG] ReserveMemory test is not
>> useful
>>>>> on Aix.
>>>>>
>>>>> Hi Goetz,
>>>>>
>>>>> On 9/06/2016 11:36 PM, Lindenmaier, Goetz wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Another small test fix for Aix. Aix does commit on touch, i.e., the page
>> is
>>>>> just
>>>>>> commited when this test wants to force an error.
>>>>>> So I just skip this test on aix.
>>>>> I think the preferred approach is to use an @requires clause to exclude
>>>>> this test from running on AIX.
>>>>>
>>>>> Thanks,
>>>>> David
>>>>>
>>>>>> I also adapted the other checks for OSes to use Platform.java.
>>>>>>
>>>>>> Please review this change. I please need a sponsor.
>>>>>> http://cr.openjdk.java.net/~goetz/wr16/8159156-
>>>>> aixResMemTest/webrev/
>>>>>> I ran the test on ppc, linuxx86_64 and darwinintel.
>>>>>>
>>>>>> Best regards,
>>>>>>    Goetz.
>>>>>>
>


More information about the hotspot-runtime-dev mailing list