PING: RFR: JDK-8156181: UL: File size limit on 32 bit Linux

[David Holmes]

On 18/06/2016 12:16 AM, Yasumasa Suenaga wrote:
> Marcus, thank you for your review!
>
> David, can I list you as a reviewer?
> I think you gave positive comment in [1].

Yes - Reviewed and sponsored.

Thanks,
David

>
> Thanks,
>
> Yasumasa
>
>
> [1]
> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-May/019380.html
>
>
>
> On 2016/06/17 22:55, Marcus Larsson wrote:
>> Hi,
>>
>>
>> On 2016-06-17 15:10, Yasumasa Suenaga wrote:
>>> PING: Could you review it?
>>>
>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8156181/webrev.00/
>>>
>>
>> Looks good to me.
>>
>> Thanks,
>> Marcus
>>
>>>
>>> Yasumasa
>>>
>>>
>>> On 2016/06/02 22:35, Yasumasa Suenaga wrote:
>>>> PING: Could you review and sponsor it?
>>>>
>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8156181/webrev.00/
>>>>
>>>> I think this is bug and should be fixed in JDK 9.
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Yasumasa
>>>>
>>>>
>>>> On 2016/05/17 19:16, Yasumasa Suenaga wrote:
>>>>> PING: Could you review and sponsor it?
>>>>>
>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8156181/webrev.00/
>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Yasumasa
>>>>>
>>>>>
>>>>> On 2016/05/06 13:53, Yasumasa Suenaga wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> This review request relates to [1] [2].
>>>>>>
>>>>>> LogFileOutput for UL uses fopen(3) to open logfile.
>>>>>> However, it might not handle > 2GB size file.
>>>>>>
>>>>>>   http://man7.org/linux/man-pages/man2/open.2.html
>>>>>>
>>>>>> Actually, JDK-7122222 added _FILE_OFFSET_BITS macro for GC log.
>>>>>> I guess we need this macro for UL.
>>>>>>
>>>>>> I uploaded webrev for this issue.
>>>>>> Could you review it?
>>>>>>
>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8156181/webrev.00/
>>>>>>
>>>>>> I cannot access JPRT.
>>>>>> So I need a sponsor.
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Yasumasa
>>>>>>
>>>>>>
>>>>>> [1]
>>>>>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-May/019311.html
>>>>>>
>>>>>> [2]
>>>>>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-May/019380.html
>>>>>>
>>>>>>
>>