RFR: 8146879: Add option for handling existing log files in UL
Marcus Larsson
marcus.larsson at oracle.com
Tue Mar 1 14:05:47 UTC 2016
Hi,
After some offline discussions I'm withdrawing this patch. I will
instead investigate if I can achieve similar behavior using log rotation
as the default.
Thanks,
Marcus
On 03/01/2016 12:11 PM, Marcus Larsson wrote:
> Hi again,
>
> Taking a different approach to this.
>
> New webrev:
> http://cr.openjdk.java.net/~mlarsson/8146879/webrev.01/
>
> Existing files will now by default be renamed/archived with a .X
> suffix where X is the lowest number such that the resulting file name
> is available (jvm.log becomes jvm.log.0). A mode option for
> controlling this behavior has been added as well. It can be set to
> archive, append, or truncate (i.e. -Xlog::jvm.log::mode=truncate).
>
> Tested with included jtreg test through JPRT.
>
> Thanks,
> Marcus
>
> On 01/14/2016 04:00 PM, Marcus Larsson wrote:
>> Hi,
>>
>> Please review the following patch to make sure UL truncates existing
>> log files before writing to them. Since files are opened in append
>> mode, truncation isn't done automatically, so instead the patch adds
>> an attempt to remove the log file before opening it.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~mlarsson/8146879/webrev.00/
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8146879
>>
>> Testing:
>> Included test through JPRT
>>
>> Thanks,
>> Marcus
>
More information about the hotspot-runtime-dev
mailing list