RFR: 8150688: Fix os_windows siglabel

Kim Barrett kim.barrett at oracle.com
Thu Mar 3 01:04:05 UTC 2016


> On Mar 2, 2016, at 2:11 PM, Tom Benson <tom.benson at oracle.com> wrote:
> 
> Looks good to me.

Thanks, Tom.

> Though as long as you're "cleaning up" line 5643, you could change the "!strcmp(...)" to "strcmp(...) == 0".   Maybe it's just me, but I've never liked the former.   Looks like the latter is used about 2 to 1 in the Hotspot source.

Looks more like 10 to 1 outside of adlc.  OK.



More information about the hotspot-runtime-dev mailing list