RFR: 8150083: Convert VerboseVerification to Unified Logging

[Rachel Protacio]

Thank you, Harold!
Rachel

On 3/7/2016 4:16 PM, harold seigel wrote:
> The latest webrev looks good.
>
> Thanks, Harold
>
> On 3/7/2016 3:19 PM, Rachel Protacio wrote:
>> Hi, Harold,
>>
>> Thanks for noticing. I have fixed as requested, in the webrev I just 
>> sent :)
>>
>> Rachel
>>
>> On 3/7/2016 11:58 AM, harold seigel wrote:
>>> Hi Rachel,
>>>
>>> The changes look good.  Are the ResourceMarks needed at lines 661 
>>> and 703 in verifier.cpp?
>>>
>>> If they are needed you can change them to ResourceMark rm(THREAD);
>>>
>>> Thanks, Harold
>>>
>>> On 3/4/2016 4:42 PM, Rachel Protacio wrote:
>>>> Hello,
>>>>
>>>> Please review this conversion of -XX:+VerboseVerification to 
>>>> -Xlog:verboseverification=info.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8150083
>>>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8150083.01/
>>>>
>>>> Sample old output:
>>>>
>>>>    Verifying class hello with new format
>>>>    Verifying method hello.<init>()V
>>>>    StackMapTable: frame_count = 0
>>>>    table = {
>>>>      }
>>>>    bci: @0
>>>>    flags: { flagThisUninit }
>>>>    locals: { uninitializedThis }
>>>>    stack: { }
>>>>    offset = 0,  opcode = aload_0
>>>>    bci: @1
>>>>    flags: { flagThisUninit }
>>>>    locals: { uninitializedThis }
>>>>    stack: { uninitializedThis }
>>>>    offset = 1,  opcode = invokespecial
>>>>    bci: @4
>>>>    flags: { }
>>>>    locals: { 'hello' }
>>>>    stack: { }
>>>>    offset = 4,  opcode = return
>>>>    Verifying method hello.main([Ljava/lang/String;)V
>>>>
>>>> Sample new output:
>>>>
>>>>    [0.696s][info][verboseverification] Verifying class
>>>>    VerboseVerificationTest$InternalClass with new format
>>>>    [0.696s][info][verboseverification] Verifying method
>>>>    VerboseVerificationTest$InternalClass.<init>()V
>>>>    [0.696s][info][verboseverification] StackMapTable: frame_count = 0
>>>>    [0.696s][info][verboseverification] table = {
>>>>    [0.696s][info][verboseverification]  }
>>>>    [0.696s][info][verboseverification] bci: @0
>>>>    [0.696s][info][verboseverification] flags: { flagThisUninit }
>>>>    [0.696s][info][verboseverification] locals: { uninitializedThis }
>>>>    [0.696s][info][verboseverification] stack: { }
>>>>    [0.696s][info][verboseverification] offset = 0,  opcode = aload_0
>>>>    [0.696s][info][verboseverification] bci: @1
>>>>    [0.696s][info][verboseverification] flags: { flagThisUninit }
>>>>    [0.696s][info][verboseverification] locals: { uninitializedThis }
>>>>    [0.696s][info][verboseverification] stack: { uninitializedThis }
>>>>    [0.696s][info][verboseverification] offset = 1,  opcode = 
>>>> invokespecial
>>>>    [0.696s][info][verboseverification] bci: @4
>>>>    [0.696s][info][verboseverification] flags: { }
>>>>    [0.696s][info][verboseverification] locals: {
>>>>    'VerboseVerificationTest$InternalClass' }
>>>>    [0.696s][info][verboseverification] stack: { }
>>>>    [0.696s][info][verboseverification] offset = 4,  opcode = return
>>>>    [0.696s][info][verboseverification] Verifying method
>>>> VerboseVerificationTest$InternalClass.main([Ljava/lang/String;)V
>>>>
>>>> Tested with JPRT; jck vm, lang, and api/java_lang; and RBT hotspot 
>>>> and non-colo tests.
>>>>
>>>> Thank you,
>>>> Rachel
>>>
>>
>