RFR: 8149995: TraceClassLoadingPreorder has been converted to Unified Logging.

Rachel Protacio rachel.protacio at oracle.com
Tue Mar 8 19:55:57 UTC 2016


Hey, Max,

Looks good. Just a few comments:

In src/share/vm/classfile/classFileParser.cpp should this have a 
ResourceMark rm(THREAD) at 5688? I realize there is probably one farther 
up in the scope, but in case someone were to delete it later, it might 
make sense to have a more local one? Not sure what the standard is on this.

Also I think you forgot to delete the option from runtime/globals.hpp.

Thanks,
Rachel


On 3/8/2016 8:33 AM, Max Ockner wrote:
> Hi,
>
> Please review this small Unified Logging change. 
> TraceClassLoadingPreorder has been converted to UL at the Debug level. 
> Debug level was chosen since there are 342 lines of output for java 
> -version.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8149995
> webrev: http://cr.openjdk.java.net/~mockner/8149995/
>
> Tested with jtreg runtime tests.
> No existing tests reference TraceClassLoadingPreorder from 
> hotspot/test or jdk/test.
>
> Thanks,
> Max



More information about the hotspot-runtime-dev mailing list