RFR (XS): 8150085: Convert TraceClearedExceptions to Unified Logging

Rachel Protacio rachel.protacio at oracle.com
Tue Mar 15 14:54:19 UTC 2016


Thanks, Max!
Rachel

On 3/15/2016 8:46 AM, Max Ockner wrote:
> Looks good to me.
> Max
>
> On 3/14/2016 2:56 PM, Rachel Protacio wrote:
>> Hi,
>>
>> Sorry for the confusion. I have previously converted TraceExceptions 
>> to Xlog:exceptions=info, so this change is merely adding the 
>> statement that was previously with TraceClearedExceptions into the 
>> "exceptions" tag, under the debug level. logging/ExceptionsTest.java 
>> tests the exceptions tag as a whole, and I did not add to it since 
>> this portion of code did not seem simple to trigger for the sake of a 
>> logging test. But of course I'm happy to add a case if someone has a 
>> specific avenue in mind.
>>
>> Rachel
>>
>> On 3/14/2016 2:48 PM, Max Ockner wrote:
>>> Rachel,
>>> I'm a bit confused to only see two files changed here. Did you leave 
>>> some files out? Did you add the tag to logTag.hpp in another fix? Is 
>>> there a test?
>>> Thanks,
>>> Max
>>>
>>> On 3/14/2016 2:23 PM, Rachel Protacio wrote:
>>>> Hi,
>>>>
>>>> Please review this change, converting -XX:+TraceClearedExceptions 
>>>> to -Xlog:exceptions=debug. (This change replaces the one I sent out 
>>>> earlier that was going to delete the option.)
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8150085
>>>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8150085.02/
>>>>
>>>> Passes JPRT; if you'd like to see additional testing, please let me 
>>>> know.
>>>>
>>>> Thank you,
>>>> Rachel
>>>
>>
>



More information about the hotspot-runtime-dev mailing list