RFR: 8146632: Add descriptive error messages for removed non-product logging flags.

[Coleen Phillimore]

Max,

I think this looks fine.  Small nit (for which I don't need to see 
another webrev).

Can you change #endif for the end of the #ifdef PRODUCT to #endif // PRODUCT

This message is so much friendlier.  Oh, and the vm doesn't crash, it 
just exits...

Thanks!
Coleen

On 3/15/16 1:45 PM, Max Ockner wrote:
> Hello again everyone!
>
> Please review this change which adds better error messages for 
> non-product flags that are now converted to Unified Logging.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8146632
> webrev: http://cr.openjdk.java.net/~mockner/8146632/
>
> Since these options have been removed, we want still want the vm to 
> crash here, but now with an error message giving the correct command 
> line option. The new message looks like this:
>
> > TraceClassInitialization has been removed. Please use 
> -Xlog:classinit instead."
>
> The entire output looks like this:
>
> > TraceClassInitialization has been removed. Please use 
> -Xlog:classinit instead.
> > Error: Could not create the Java Virtual Machine.
> > Error: A fatal exception has occurred. Program will exit.
>
> Tested with jtreg runtime tests. A new test checks for an appropriate 
> error message for every develop flag that has so far been converted to 
> logging.
>
> Thanks,
> Max
>
>