RFR (M): 8142510: rev2: -XX:+PrintFlagsRanges should print default range value for those flags that have constraint and an implicit range.

Dmitry Dmitriev dmitry.dmitriev at oracle.com
Thu Mar 17 13:29:01 UTC 2016


Hi Gerard,

Looks good, except copyrights years in the following modules(forgot 
about that in the first round):
commandLineFlagConstraintList.cpp
commandLineFlagConstraintList.hpp
commandLineFlagRangeList.hpp

Not need a new webrev for that.

Thanks,
Dmitry

On 16.03.2016 19:55, Gerard Ziemski wrote:
> hi all,
>
> This is rev2 of the fix incorporating feedback from Dmitry:
>
> - re-use "CommandLineFlagConstraintList::find()"
>
> Please review this enhancement to Command Line Options Validation JEP-245, which prints default ranges for those flags, that only have constraints (ie. no range, but a constraint, implies default range)
>
> With this fix we’ll be able to include more flags in test/runtime/CommandLine/OptionsValidation test.
>
>
> bug https://bugs.openjdk.java.net/browse/JDK-8142510
> webrev http://cr.openjdk.java.net/~gziemski/8142510_rev2
>
> tested with JPRT hotspot, RBT hotspot/test/runtime and local test/runtime/CommandLine/OptionsValidation
>
>
> cheers



More information about the hotspot-runtime-dev mailing list