RFR(S): 8075253: Multiversion JAR feature: CDS does not support MV-JARs

Calvin Cheung calvin.cheung at oracle.com
Fri Mar 18 21:03:50 UTC 2016


Typo in the email:
"Multi-release" -> "Multi-Release"

Testing:
     JPRT -testset hotspot
     all tests under the hotspot_runtime testlist

thanks,
Calvin

On 3/18/16, 1:51 PM, Calvin Cheung wrote:
>
> This fix was reviewed in Aug 2015[1] though most of the review 
> comments was via internal mailing list. Recently, the JEP 238 
> (Multiple-Release jar files) has been checked into jdk9. So it is time 
> to make the corresponding changes in hotspot.
>
> JBS: bug: https://bugs.openjdk.java.net/browse/JDK-8075253
>       (unfortunately the bug was marked as "confidential")
>
> webrev: http://cr.openjdk.java.net/~ccheung/8075253/webrev.00/
>
> Some adjustments need to be made due to:
> - attribute name in the jar manifest has been changed to "Multi-release";
> - system property has been changed to jdk.util.jar.enableMultiRelease 
> and it has value of "true", "force" or "false".
>
> The diff between this patch and the reviewed patch is as follows:
>
> 11c11
> < +    const char* multi_ver = 
> Arguments::get_property("jdk.util.jar.enableMultiRelease");
> ---
> > +    const char* multi_ver = 
> Arguments::get_property("jdk.util.jar.multiversion");
> 14c14
> < +                         strcmp(multi_ver, "true") == 0 ||
> ---
> > +                         strcmp(multi_ver, "enable") == 0 ||
> 64c64
> < @@ -296,6 +345,17 @@
> ---
> > @@ -272,6 +321,17 @@
> 72c72
> < +    if (strstr(buffer, "Multi-Release: true") != NULL) {
> ---
> > +    if (strstr(buffer, "Multiversion: true") != NULL) {
>
> thanks,
> Calvin
>
> [1]: 
> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-August/015589.html


More information about the hotspot-runtime-dev mailing list