RFR (S) 8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java

Ioi Lam ioi.lam at oracle.com
Mon Mar 21 21:51:30 UTC 2016


Hi Coleen,

Just to double check that my understanding is correct -- the code that 
you added affects only non-product builds, when the string table is 
verified. There's no impact on the lookup or insertion of the StringTable.

If that's the case, the changes look good to me. It's a little slower 
than before, but it only slows down non-product builds.

Thanks
- Ioi

On 3/21/16 2:11 PM, Coleen Phillimore wrote:
> Summary: Fix code broken with compact Strings.
>
> One of the failure modes of an intermittent bug (but this failure is 
> not intermittent).
>
> Tested with the failing test cases that exercise this code. Also, 
> testing in order to find linked bugs.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8144940.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8144940
>
> Thanks,
> Coleen



More information about the hotspot-runtime-dev mailing list