RFR (S) 8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java

[Tobias Hartmann]

Hi Coleen,

On 21.03.2016 22:11, Coleen Phillimore wrote:
> Summary: Fix code broken with compact Strings.
> 
> One of the failure modes of an intermittent bug (but this failure is not intermittent).
> 
> Tested with the failing test cases that exercise this code. Also, testing in order to find linked bugs.
> 
> open webrev at http://cr.openjdk.java.net/~coleenp/8144940.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8144940

I wonder why the result is different if you first convert the latin1 String to Unicode and then use the jchar hash_string() version compared to just using the jbyte hash_string() version? Is it because the jbyte version of AltHashing::murmur3_32() is used?

Now we don't need the StringTable::hash_string<jbyte> version anymore, right?
Just noticed that there is an unused "latin1_hash_code" in javaClasses.hpp which can be removed as well.

Thanks for fixing this!

Best regards,
Tobias

> 
> Thanks,
> Coleen