RFR(S) 8140665: SIGSEGV when a primitive type's class is used as the host class in a call to DefineAnonymousClass call
Karen Kinnear
karen.kinnear at oracle.com
Tue Mar 22 14:57:04 UTC 2016
Harold,
Thank you for fixing this. Looks good.
One question -
1. If you were to pass in a null host_class in product - what happens?
The way I read the resolve_non_null, it asserts in debug that you did not pass in a null, which suggests to me that it assumes
we have already made that check. I would expect and if (host_class == NULL) || … 0> IllegalArgumentException ?
thanks,
Karen
> On Mar 22, 2016, at 10:23 AM, harold seigel <harold.seigel at oracle.com> wrote:
>
> Hi,
>
> Please review this small change to fix bug 8140665.
>
> Instead of asserting or getting a SIGSEGV when trying to define an anonymous class when the host class is a primitive type, this fix throws an IllegalArgumentException.
>
> Webrev: http://cr.openjdk.java.net/~hseigel/bug_8140665/
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8140665
>
> The fix was tested with JCK Lang and VM java_lang tests, the UTE non-collated quick tests, and the hotspot, JDK vm, java/io, java/lang, java/util and JFR JTreg tests, and the test included in this RFR.
>
> Thanks, Harold
More information about the hotspot-runtime-dev
mailing list