RFR: 8146947: Remove PrintOopAddress rather than converting to UL

Coleen Phillimore coleen.phillimore at oracle.com
Tue Mar 22 16:09:59 UTC 2016


Hi Rachel,

http://cr.openjdk.java.net/~rprotacio/8146947/src/share/vm/oops/oop.cpp.udiff.html

I think the line

*-if (PrintOopAddress)print_address_on(st);*


should be removed.   For the case of a String that is in output for 
logging, it doesn't seem like it adds anything and then you wouldn't 
have to change the tests.

Thanks,
Coleen

On 3/22/16 10:08 AM, Rachel Protacio wrote:
> Hello,
>
> Please review this fix removing PrintOopAddress as a command line 
> flag. The printing functionality has been made default, except for one 
> block which has been removed (see bug description for justification). 
> A compatibility request has been accepted with respect to this change.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8146947
> Open webrev: http://cr.openjdk.java.net/~rprotacio/8146947/
>
> Passes JPRT and RBT hotspot and non-colo testing.
>
> Thank you,
> Rachel



More information about the hotspot-runtime-dev mailing list