RFR (S) 8144940: Broken hash in string table entry in closed/runtime/7158800/BadUtf8.java

[Coleen Phillimore]

Thanks Harold!
Coleen

On 3/22/16 1:04 PM, harold seigel wrote:
> Hi Coleen,
>
> The changes look good.
>
> Harold
>
> On 3/21/2016 7:05 PM, Coleen Phillimore wrote:
>>
>>
>> On 3/21/16 5:51 PM, Ioi Lam wrote:
>>> Hi Coleen,
>>>
>>> Just to double check that my understanding is correct -- the code 
>>> that you added affects only non-product builds, when the string 
>>> table is verified. There's no impact on the lookup or insertion of 
>>> the StringTable.
>>
>> Yes, it is only verification code, which is enabled in product builds 
>> but is not turned on by default unless you use one of the 
>> Verify{Before,After,During}GC or VerifyBeforeExit options.
>>>
>>> If that's the case, the changes look good to me. It's a little 
>>> slower than before, but it only slows down non-product builds.
>>
>> Yes, I guess it is but it has to be correct.  String::intern() uses 
>> the unicode representation of the string for the hash.
>>
>> Thanks!
>> Coleen
>>>
>>> Thanks
>>> - Ioi
>>>
>>> On 3/21/16 2:11 PM, Coleen Phillimore wrote:
>>>> Summary: Fix code broken with compact Strings.
>>>>
>>>> One of the failure modes of an intermittent bug (but this failure 
>>>> is not intermittent).
>>>>
>>>> Tested with the failing test cases that exercise this code. Also, 
>>>> testing in order to find linked bugs.
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8144940.01/webrev
>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8144940
>>>>
>>>> Thanks,
>>>> Coleen
>>>
>>
>