RFR (S): 8136766: Enable ThreadStackSize range test

[Gerard Ziemski]

Thank you Dan.

You are right and I will have to re-do this. For now I am withdrawing this RFR.


cheers
 
> On Mar 29, 2016, at 2:10 PM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> 
> The special treatment of '0' for the various thread stack size options
> is not limited to Windows. I believe that for all platforms, specifying
> a value of '0' means use the platform default. This should be true for
> ThreadStackSize, CompilerThreadStackSize and CompilerThreadStackSize
> options.
> 
> Dan
> 
> 
> On 3/29/16 12:50 PM, Gerard Ziemski wrote:
>> hi Ron,
>> 
>> This change is needed to enable running ThreadStackSize as part of the TestOptionsWithRanges test.
>> 
>> ThreadStackSize needed its range implemented in platform dependent way, where on Windows 0 means “use os defaults” - please see Dan’s comment in the issue for more background.
>> 
>> 
>> cheers
>> 
>>> On Mar 29, 2016, at 12:57 PM, Ron Durbin <ron.durbin at oracle.com> wrote:
>>> 
>>> Gerard,
>>> 
>>> I have run the Options Range Test dozens of times with only the Max test disabled for ThreadStackSize.
>>> I have not seen this failure of the min test on windows.  I would like to understand why this change is
>>> needed.
>>> 
>>> Ron
>>> 
>>>> -----Original Message-----
>>>> From: Gerard Ziemski
>>>> Sent: Friday, March 25, 2016 10:27 AM
>>>> To: hotspot-runtime-dev at openjdk.java.net
>>>> Subject: RFR (S): 8136766: Enable ThreadStackSize range test
>>>> 
>>>> hi all,
>>>> 
>>>> Please review this small fix which fixes the range (in platform dependent way where 0 has a special meaning on
>>>> Windows) and adds constraint for ThreadStackSize, which allows us to include it in
>>>> test/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java test.
>>>> 
>>>> https://bugs.openjdk.java.net/browse/JDK-8136766
>>>> http://cr.openjdk.java.net/~gziemski/8136766_rev1
>>>> 
>>>> Passes JPRT hotspot and RBT CommandLine/OptionsValidation/TestOptionsWithRanges on all platforms.
>