RFR: JDK-8153073: UL: Set filesize option with k/m/g

[Marcus Larsson]

Hi,

On 03/30/2016 04:09 PM, Yasumasa Suenaga wrote:
> Hi all,
>
> This request review is related to [1].
>
> I want to set filesize option with k/m/g as below: 
>            -Xlog:gc=trace:file=gc.log:time:filecount=5,filesize=10m 
>
> Memory size option (e.g. -Xmx) can be set with k/m/g .
> I think we can use option parser in arguments.cpp . 
>
> I uploaded webrev. Could you review it?
>
>   http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.00/

You're missing an include of arguments.hpp in logFileOutput.cpp.

Apart from that, this looks good to me.

Thanks,
Marcus

>
>
> I cannot access JPRT. So I need a sponsor.
>
>
> Thanks,
>
> Yasumasa
>
>
> [1] http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-March/018704.html
>