RFR: JDK-8153191: UL: Separator in VM.log output is redundant

[Yasumasa Suenaga]

Hi Marcus,

> Please see
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-March/019237.html
> for the configuration string issue. It was sent out earlier today.

Sorry, I was not check it.
I closed JDK-8153191 as duplicate.


> Also, please note that UL belongs to the serviceability subcomponent,
> and patches like this should probably go to the serviceability-dev
> mailing list.

Thanks!


Yasumasa


On 2016/03/31 22:11, Marcus Larsson wrote:
> Hi,
> 
> On 03/31/2016 02:50 PM, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> We can check log configuration through VM.log list jcmd:
>> -------
>> Log output configuration:
>> #0: stdout vmoperation=debug,safepoint=info, uptime,level,tags,
>> #1: stderr all=warning uptime,level,tags,
>> #2: gc.log gc=trace, uptime,level,tags,
>> -------
>>
>> Configuration string and decorators are ended with comma.
>> We should remove it as below:
>> -------
>> Log output configuration:
>> #0: stdout vmoperation=debug,safepoint=info uptime,level,tags
>> #1: stderr all=warning uptime,level,tags
>> #2: gc.log gc=trace uptime,level,tags
>> -------
>>
>>
>> I uploaded webrev for this issue.
>> Could you review it?
>>
>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8153191/webrev.00/
> 
> Please see
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-March/019237.html
> for the configuration string issue. It was sent out earlier today.
> 
> Your suggested fix for the decorator listing is broken. The for loop you
> modified iterates over all possible decorators, not all enabled
> decorators. So unless you have the last possible decorator enabled you
> will still get a trailing comma.
> 
> Also, please note that UL belongs to the serviceability subcomponent,
> and patches like this should probably go to the serviceability-dev
> mailing list.
> 
> Thanks,
> Marcus
> 
>>
>>
>> I cannot access JPRT.
>> So I need a sponsor.
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>>
>