RFR: JDK-8155936: Boolean value should be set 1/0 or true/false via VM.set_flag jcmd
Gerard Ziemski
gerard.ziemski at oracle.com
Tue May 3 18:18:12 UTC 2016
hi Yasumasa,
Thank you for the fix, I like it - the very first time I tried using jcmd to set a boolean value I tried using “true”, so this will make jcmd easier to use.
Reviewed and I will sponsor it.
Just one question: there is no existing JDK issue covering this yet, is there? Can you file one please if none exists yet?
cheers
> On May 3, 2016, at 9:22 AM, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
>
> Hi all,
>
> This review request relates to [1].
>
> We can change a part of -XX option via VM.set_flag jcmd.
> This jcmd requires 1 or 0 as boolean value.
> However, we can set 0 or not (NOT 1).
>
> In jinfo, we can set boolean value with 1/0 or +/-.
> So I think it is useful if VM.set_flag accept boolean value in true/false.
>
> I uploaded a webrev for this issue.
> Could you review it?
>
> http://cr.openjdk.java.net/~ysuenaga/JDK-8155936/webrev.00/
>
> I cannot access JPRT.
> So I need a sponsor.
>
>
> Thanks,
>
> Yasumasa
>
>
> [1] http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-April/019192.html
More information about the hotspot-runtime-dev
mailing list