RFR(xs): 8155639: Remove STEP numbers from error reporting

[Christian Thalinger]

> On May 2, 2016, at 8:41 PM, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
> 
> Coleen, Christian, thank you!
> 
> New webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8155639-STEP-number-removal/webrev.01/webrev/ <http://cr.openjdk.java.net/~stuefe/webrevs/8155639-STEP-number-removal/webrev.01/webrev/>
> 
> I removed the parenthesizes from the step numbers as Christian requested, the rest is the same. 

Thanks.

> 
> I did not know if Christian did a full review, so I only added Coleen as Reviewer.

I did a full review.

> 
> Kind Regards, Thomas
> 
> 
> 
> On Mon, May 2, 2016 at 10:09 PM, Christian Thalinger <christian.thalinger at oracle.com <mailto:christian.thalinger at oracle.com>> wrote:
> Could we also move the parenthesis into the STEP macro?
> 
> -  STEP(20, "(test secondary crash 1)")
> +  STEP("test secondary crash 1")
> 
>> On Apr 28, 2016, at 3:48 AM, Thomas Stüfe <thomas.stuefe at gmail.com <mailto:thomas.stuefe at gmail.com>> wrote:
>> 
>> Hi,
>> 
>> may I have reviews and a sponsor for the following small improvement?
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8155639 <https://bugs.openjdk.java.net/browse/JDK-8155639>
>> webrev:
>> http://cr.openjdk.java.net/~stuefe/webrevs/8155639-STEP-number-removal/webrev.00/webrev/ <http://cr.openjdk.java.net/~stuefe/webrevs/8155639-STEP-number-removal/webrev.00/webrev/>
>> 
>> Basically, this change proposes to get rid of the hand-coded STEP numbers
>> in error reporting in favour of using the __LINE__ macro.
>> 
>> The hand-coded step numbers are a constant source or errors, as they need
>> to maintained in monotonous order and if they are not, error reporting
>> steps are just quietly swallowed.
>> 
>> Using the __LINE__ macro would be self-maintaining and thus much more
>> robust.
>> 
>> Thank you!
>> 
>> Thomas
> 
>