RFR 8144279 [TESTBUG] hotspot/runtime/jsig/Test8017498.sh should use native library build support
Calvin Cheung
calvin.cheung at oracle.com
Thu May 5 17:31:16 UTC 2016
Hi Jerry,
On 5/3/16, 2:54 PM, Gerald Thornbrugh wrote:
> Hi Everyone,
>
> I would like to have the following change reviewed:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8144279
> Webrev: http://cr.openjdk.java.net/~gthornbr/8144279/webrev.00/
> <http://cr.openjdk.java.net/%7Egthornbr/8144279/webrev.00/>
The change looks good.
>
> JPRT testing completed without errors and I verified that the test was
> run.
>
>
> The changes consist of:
>
> Replacing the existing Test8017498.sh script file with a java test
> source file Testjsig.java.
>
> Adding the test directory to the "BUILD_HOTSPOT_JTREG_NATIVE_SRC" list
> for Linux builds
> so the native libTestJNI.c source file would be compiled into a native
> library.
>
> Renaming the existing TestJNI.c native source file to libTestJNI.c so
> the build process would
> identify the file as a native library source file and build the library.
For this, I think you can use "hg rename" so that the revision history
of the original file is kept.
Something like:
cd <repo>/hotspot/test/runtime/jsig
hg rename TestJNI.c lib/libTestJNI.c
thanks,
Calvin
>
> Please let me know if you have any questions or concerns.
>
> Thanks,
>
> Jerry
More information about the hotspot-runtime-dev
mailing list