RFR: 8154791: Xlog classload too redundant msgs info/debug

[Ioi Lam]

Max,

Does this mean that the class loading log is always printed. Or at 
least, all the formatting in instanceKlass::print_loading_log() is done 
and the stuff is printed to a NULL stream?

classFileParser.cpp:

     ik->print_loading_log(_loader_data, module_name, _stream);

InstanceKlass::print_loading_log(...) {
   outputStream* log = Log(class, load)::info_stream();
   // Name and class hierarchy info
   log->print("%s", external_name());
   ...
}

I think you should add a quick test in print_loading_log() and return if 
(class, load) is not enabled.

As usual, it would be helpful for the reviewers if you can include a 
small sample of the output (before and after).

Thanks
- Ioi

On 5/9/16 12:06 PM, Coleen Phillimore wrote:
>
> Max, This looks a lot nicer.
> Thanks,
> Coleen
>
>
> On 5/9/16 2:43 PM, Max Ockner wrote:
>> Hello,
>>
>> Please review this small change to logging for class loading.
>>
>> Webrev: http://cr.openjdk.java.net/~mockner/8154791.02/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154791
>>
>> -Xlog:class+load=debug used to produce redundant info. Some of the 
>> debug level lines were nearly identical to some of the info level 
>> lines. To reduce the redundant information, these debug messages have 
>> been moved into the info level, replacing the corresponding info 
>> messages.
>>
>> Tested with jtreg runtime.
>>
>> I can wait to submit this until after the FC deadline.
>>
>> Thanks,
>> Max
>