RFR(XXS): 8156777: [TESTBUG] test/testlibrary_tests/SimpleClassFileLoadHookTest.java requires non minimal VM

George Triantafillou george.triantafillou at oracle.com
Wed May 11 17:31:10 UTC 2016


+1

-George


On 5/11/2016 1:02 PM, mikhailo wrote:
> Fix looks good to me.
>
> Thank you,
> Misha
>
> On 05/11/2016 09:36 AM, Leonid Mesnik wrote:
>> Hi
>> <https://bugs.openjdk.java.net/browse/JDK-8156777>
>> Could you please review this extra small fix which add @requires to 
>> the single test. This test is not compatible with minimal VM even it 
>> doesn't require any specific modules outside compact2. So I've just 
>> added corresponding @requires.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8156777
>>
>> Tested by manual jtreg execution with -minimal/-client/default vm 
>> options.
>>
>> Fix inlined:
>>
>> --- a/test/testlibrary_tests/SimpleClassFileLoadHookTest.java Wed May 
>> 11 02:32:14 2016 -0400
>> +++ b/test/testlibrary_tests/SimpleClassFileLoadHookTest.java Wed May 
>> 11 19:24:34 2016 +0300
>> @@ -24,7 +24,7 @@
>>  /*
>>   * @test
>>   * @library /testlibrary
>> - *
>> + * @requires vm.flavor != "minimal"
>>   * @run main/othervm/native 
>> -agentlib:SimpleClassFileLoadHook=Foo,XXX,YYY
>>   *      SimpleClassFileLoadHookTest
>>   */
>>
>>
>> Leonid
>



More information about the hotspot-runtime-dev mailing list