RFR(XS): 8156929: [aix] Add missing includes.

[David Holmes]

Thinking more ...

On 13/05/2016 11:18 PM, David Holmes wrote:
> On 13/05/2016 11:09 PM, Lindenmaier, Goetz wrote:
>> Hi,
>>
>> I had problems with the dbg build (didn't try opt) and without
>> precompiled headers.
>>
>>> In mutex.cpp there is no aix version of
>>>
>>>   #ifdef TARGET_OS_FAMILY_linux
>>>   # include "mutex_linux.inline.hpp"
>>>   #endif
>> Yes, but that file is empty.  They should be removed.
>> And mutex.cpp should be self-contained with its includes.
>
> I see. So the other platforms are getting the missing includes from the
> mutex_<os>.inline.hpp file and they don't actually contain anything
> inline just a few includes - which is weird. That said I consider the
> inline.hpp file part of the mutex.cpp file in terms of being "self
> contained".
>
>>> which definition is coming from the missing include ??
>> The new operator.
>
> Have to wonder where that comes from on other platforms.

This seems wrong to me. You should not need to include 
allocation.inline.hpp because you use operator new for a class! To do 
"new G1HeapSizingPolicy" all you should need to include is 
g1HeapSizingPolicy.hpp.

David
-----

> But okay - thanks for clarifying. Wish there was a tool to sort out
> include dependencies .. oh wait, there was ;-)
>
> Cheers,
> David
>
>> Best regards,
>>   Goetz.
>>
>>
>>