RFR: 8157097 (was 8157133): CompactHashtableWriter SIGFPE when num bucket is zero

David Holmes david.holmes at oracle.com
Mon May 23 07:17:52 UTC 2016


Hi Robbin,

This seems okay as an immediate fix for the test problem.

But I'm not completely clear on the bucket calculation logic as it seems 
we will put nearly 2x the number of entries in the first bucket. So 
please file a follow up bug for that - or discuss with someone more 
knowledgeable about the code to see if it is an issue or not.

Thanks,
David

> Hi Jiangli,
>
> Sorry for not spotting the dup.
>
> On 05/17/2016 06:16 PM, Jiangli Zhou wrote:
>> Hi Robbin,
>>
>> Looks good. Thanks for fixing this!
>
> Thanks!
>
> So this goes on 8157097 instead!
>
> /Robbin
>
>>
>> Thanks,
>> Jiangli
>>
>>> On May 17, 2016, at 6:43 AM, Robbin Ehn <robbin.ehn at oracle.com> wrote:
>>>
>>> Hi all,
>>>
>>> Please review!
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8157133
>>> Webrev: http://cr.openjdk.java.net/~rehn/8157133/webrev/
>>>
>>> Tested with hotspot_jprt and hotspot/test/runtime/CommandLine/OptionsValidation/
>>>
>>> Thanks!
>>>
>>> /Robbin
>>



More information about the hotspot-runtime-dev mailing list