RFR: 8152404: Stabilize PackageEntry::package_exports_do

[David Holmes]

Hi Rachel,

On 26/05/2016 1:10 AM, Rachel Protacio wrote:
> Hello,
>
> Please review this bug fix for some module export checking code. The
> PackageEntry::package_exports_do() function had assumed calling
> is_qual_exported() would verify that _qualified_exports was not NULL,
> but as that was not the case, I've re-defined the PackageEntry member
> variables and export checking functions.

In src/share/vm/classfile/packageEntry.hpp the documentation no longer 
makes it clear how the three variables are defined for the four 
different situation ie for an unnamed export what are the values of 
_qualified_exports and _is_exported_unqualified?

Overall (given I'm not familiar with the different export qualities) I 
found it a little unclear how the different states were defined and what 
the legal transitions are between them. I would have expected to see 
more assertions regarding those three state variables, and checks for 
when they get set or cleared. In one place you actually removed such an 
assertion.

Thanks,
David

> Passes JPRT, jck (vm, lang, and api/java_lang), and RBT hotspot_all and
> non-colo tests.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8152404
> Open webrev: http://cr.openjdk.java.net/~rprotacio/8152404.00/
>
> Thanks,
> Rachel