RFR(XS) 8158060: BasicLayerTest causes fatal error: Thread holding lock at safepoint that vm can block on: Module_lock

[David Holmes]

Hi Harold,

On 31/05/2016 3:09 AM, harold seigel wrote:
> Hi,
>
> Please review this small change to fix bug 8158060.  The fix moves the
> exception throw to outside of the block containing the module lock.
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8158060
>
> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8158060/

Fix looks good.

Though I'm wondering - do we ever actually acquire the Module_lock as 
part of a VMOperation? (I know we are very conservative with this :) ).

Thanks,
David

> The fix was tested with an RBT nightly test run and with the failing test.
>
> Thanks, Harold
>