RFR (XS): 8074085: os::get_native_stack() could use some cleanup

[David Holmes]

On 31/05/2016 8:01 PM, David Holmes wrote:
> Hi,
>
> On 31/05/2016 7:40 PM, Всеволод Толстопятов wrote:
>> Hi,
>> Could you please review and sponsor simple cleanup for
>> os::get_native_stack() in os_posix.cpp?
>>
>> CR: *https://bugs.openjdk.java.net/browse/JDK-8074085
>> <https://bugs.openjdk.java.net/browse/JDK-8074085>*
>> Webrev:
>> *http://cr.openjdk.java.net/~fzhinkin/vtolstopyatov/8074085/webrev.00/
>> <http://cr.openjdk.java.net/~fzhinkin/vtolstopyatov/8074085/webrev.00/>*
>> Testing: hotspot_runtime tests, except jasm and jcoder ones
>
> You seem to have lost the check for fr.sender_pc() == NULL.

Sorry just read the bug report.

Unfortunately as we are past feature complete this enhancement can't go 
in without going through the yet-to-be-defined approval process.

Also I'm a little unclear how to handle this submission as you can't 
really claim to be the contributor when the code change is listed in the 
bug report. ??

Cheers,
David


> David
>
>> --
>> Best regards,
>> Tolstopyatov Vsevolod
>>