Request Review: JDK-6479237 (cl) Add support for classloader names

[Coleen Phillimore]

On 11/3/16 12:29 PM, Mandy Chung wrote:
>> On Nov 3, 2016, at 8:52 AM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
>>
>> My problem with fillStackTraceFromThrowable, besides it being a really long name, is that it's too close to fillInStackTrace which is a known API and should not be changed.
>>
>> Why not keep JVM_ToStackTraceElement, and change JVM_GetStackTraceElements if you really need to to JVM_ToStackTraceElementArray().
>>
>> Or even JVM_ToStackTraceElements() which is very close to the function that it should conceptually be an overloaded instance.
>>
>> Throwable is part of the API, so putting it in the name is redundant and too long.  Sorry for caring maybe overly about the names. That's how I find things.
> These two methods are part of StackTraceElement APIs not Throwable, in case it’s not clear to you.

Yes, I know but the parameter to the one is Throwable, which is what I 
meant.
>
> What about SetStackTraceElement* or another alternative InitStackTraceElement*
>
> JNIEXPORT void JNICALL
> JVM_SetStackTraceElementArray(JNIEnv *env, jobjectArray elements, jobject throwable);
>
> JNIEXPORT void JNICALL
> JVM_SetStackTraceElement(JNIEnv* env, jobject element, jobject stackFrameInfo);

Ok.  These names are better.   And they'd match the java method name, right?
> BTW - do you know any known issue as JPRT hotspot test jobs are failing on jdk9/hs and jdk9/dev?

No, they shouldn't fail unless the machines are down, which they could 
be.  All hotspot changes are tested in hs with each repository push.  
Can you rebase this for hs repository (in case that request got lost in 
the discussion)?

Thanks so much,
Coleen
> Mandy