RFR (XS): 8160024 jdb returns invalid argument count if first parameter to Arrays.asList is null

Dmitry Samersoff dmitry.samersoff at oracle.com
Fri Nov 4 12:31:19 UTC 2016


Looks good to me.

PS: It might be better to refactor this code sometimes to don't check
the same things multiple time.


On 2016-11-01 15:58, serguei.spitsyn at oracle.com wrote:
> Please, review this small fix.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8160024
> JDK webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8160024-JDI-eval.jdk1/
> The bug is confidential, so the RFR is sent to the confidential mailing
> lists.
> Summary:
>   The JDI incorrectly evaluates the expression: Arrays.asList(null, "a").
>   The root cause is a special case in the method MethodImpl.handleVarArgs()
>   that has been corrected in order to fix the problem.
>   New unit test is included: jdk/test/com/sun/jdi/EvalArraysAsList.sh
> Testing:
>   Ran new unit test, Jtreg com/sun/jdi and nsk.jdi.testlist.
>   All tests are passed.
> Thanks,
> Serguei

Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.

More information about the hotspot-runtime-dev mailing list