RFR(xs): 8168796: relax vm options checking during CDS dump time

[Calvin Cheung]

Thank you, Serguei.

Calvin

On 11/10/16, 4:43 PM, serguei.spitsyn at oracle.com wrote:
> Hi Calvin,
>
> Looks good.
>
> Thanks,
> Serguei
>
>
> On 11/10/16 15:42, Calvin Cheung wrote:
>> Hi Harold, Jiangli,
>>
>> Thanks for your review.
>>
>> I've updated the webrev based on your review comments:
>>     http://cr.openjdk.java.net/~ccheung/8168796/webrev.01/
>>
>> thanks,
>> Calvin
>>
>> On 11/10/16, 11:52 AM, Jiangli Zhou wrote:
>>> +1
>>>
>>> Thanks,
>>> Jiangli
>>>
>>>> On Nov 10, 2016, at 11:42 AM, harold 
>>>> seigel<harold.seigel at oracle.com>  wrote:
>>>>
>>>> Hi Calvin,
>>>>
>>>> The changes look good.  Could you add a comment to the declaration 
>>>> of warning_idx explaining what it means to be above and below the 
>>>> that index?
>>>>
>>>> Also, instead of calling tty->print_cr(), can you call warning(), 
>>>> instead?
>>>>
>>>> Thanks, Harold
>>>>
>>>>
>>>> On 11/10/2016 2:33 PM, Calvin Cheung wrote:
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8168796
>>>>>
>>>>> webrev: http://cr.openjdk.java.net/~ccheung/8168796/webrev.00/
>>>>>
>>>>> Before this change, if any one of the following vm options 
>>>>> ("-module-path", "-add-modules", "--upgrade-module-path") is 
>>>>> specified during CDS dump time, the vm exits with an error as 
>>>>> follows:
>>>>>
>>>>> bash-4.1$ java --upgrade-module-path=/tmp -Xshare:dump
>>>>> Error occurred during initialization of VM
>>>>> Cannot use the following option when dumping the shared archive: 
>>>>> --upgrade-module-path
>>>>>
>>>>> This change will print a warning message and continues as follows:
>>>>>
>>>>> bash-4.1$ java --upgrade-module-path=/tmp -Xshare:dump
>>>>> Warning: the --upgrade-module-path option is ignored when dumping 
>>>>> the shared archive
>>>>> Allocated shared space: 50577408 bytes at 0x0000000800000000
>>>>> Loading classes to share ...
>>>>>
>>>>> Test case is in the hotspot closed repo.
>>>>>
>>>>> Testing:
>>>>>     JPRT
>>>>>     all tests under hotspot/test/runtime
>>>>>
>>>>> thanks,
>>>>> Calvin
>>>>>
>>>>>
>>>>>
>