RFR: JDK-8160997 Solaris: deprecated <pwd.h> and <gid.h> interfaces should be replaced

[Dmitry Samersoff]

David,

OK. Sorry!

-Dmitry

On 2016-11-16 08:28, David Holmes wrote:
> Hi Dmitry,
> 
> This changeset was pushed at the end of July!
> 
> David
> 
> On 16/11/2016 3:04 AM, Dmitry Samersoff wrote:
>> Alan,
>>
>> Solaris.c:73
>>
>> if (getpwuid_r(getuid(), &pwd, pwd_buf, sizeof(pwd_buf), &p) != NULL
>>
>> getpwuid_r returns int and we have to check that p is not null.
>>
>>
>> Otherwise looks good to me.
>>
>> -Dmitry
>>
>>
>>
>> On 2016-07-11 16:22, Alan Burlison wrote:
>>> Hi, I'd like to ask for reviews for:
>>>
>>> JDK-8160997 Solaris: deprecated <pwd.h> and <gid.h> interfaces should be
>>> replaced
>>>
>>> This is to remove code that was a workaround that was needed for Solaris
>>> 2.4. In 2.4 we implemented interfaces from the draft of POSIX.1c Draft 6
>>> which then changed in the final POSIX release, and we were then stuck
>>> with the warts.
>>>
>>> For Solaris 11, defining the macro _POSIX_PTHREAD_SEMANTICS enables the
>>> 'official' POSIX information and means that the code which works on
>>> Linux etc also works the same on Solaris, so the Solaris-specific
>>> workarounds can be removed.
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8160997
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~dcubed/for_alanbur/8160997-webrev/0-jdk9-hs-all/
>>>
>>>
>>>
>>> JPRT + the hotspot testset was clean.
>>>
>>
>>


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.