RFR(M): 8165550: Add class loader names to ClassCastException message
rachel.protacio at oracle.com
Thu Nov 17 19:24:53 UTC 2016
Thanks for the review, Lois! Will fix.
On 11/17/2016 2:19 PM, Lois Foltan wrote:
> On 11/17/2016 11:36 AM, Rachel Protacio wrote:
>> Last one! http://cr.openjdk.java.net/~rprotacio/8165550.03
>> - Thanks to Lois, I've added a new test case for a custom-named
>> class loader with the unnamed module, and also throw an exception in
>> the test if no CCE is thrown.
>> - Thanks to Mandy and Coleen, I've corrected the part of my code
>> getting the Class Loader Name, which ironically, I was doing
>> incorrectly before.
> Looks good Rachel! Minor nit that I don't need to see another webrev
> for, the test case only needs the "2016" date in the copyright, not
> "2015" as well.
>> On 11/15/2016 4:03 PM, Mandy Chung wrote:
>>>> On Nov 15, 2016, at 12:49 PM, Rachel Protacio
>>>> <rachel.protacio at oracle.com> wrote:
>>>> Updated webrev: http://cr.openjdk.java.net/~rprotacio/8165550.02/
>>>> - added macro in ModuleEntry.hpp for "java.base" to address
>>>> Lois' comment (opened enhancement
>>>> https://bugs.openjdk.java.net/browse/JDK-8169734 for other existing
>>>> - added an assert instead of a NULL check for the class loader
>>>> - fixed NEW_RESOURCE_ARRAY_RETURN_NULL calls
>>> Looks okay to me. It’d be good if you can add a test case testing a
>>> custom named class loader with unnamed module.
More information about the hotspot-runtime-dev