RFR(S): 8168493: Convert TestBitMap_test to GTest

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Tue Nov 22 15:00:00 UTC 2016


Thomas,

Thank you for review!

Regards, Kirill

On 22.11.2016 16:50, Thomas Schatzl wrote:
> Hi Kirill,
>
> On Tue, 2016-11-01 at 16:45 +0300, Kirill Zhaldybin wrote:
>> Dear all,
>>
>> Could you please review this fix for 8168493?
>>
>> WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8168493/webr
>> ev.00/
>> CR: https://bugs.openjdk.java.net/browse/JDK-8168493
>>
>> Changes:
>> 1. Usual gtest conversion - asserts, file location etc
>> 2. Simplified the test a bit - deleted unused template parameter,
>> refactoring
>> 3. Deleted friend class from BitMap class since we actually do not
>> need it
>>
>> Thank you.
>>
>    conversion looks good.
>
> Thanks,
>    Thomas
>



More information about the hotspot-runtime-dev mailing list