RFR(S): 8166156: Convert test_semaphore to GTest
Kirill Zhaldybin
kirill.zhaldybin at oracle.com
Mon Nov 28 16:08:53 UTC 2016
Stefan,
Thank you for review!
Regards, Kirill
On 28.11.2016 18:58, Stefan Karlsson wrote:
> Looks good.
>
> Thanks,
> StefanK
>
> On 2016-11-28 16:59, Kirill Zhaldybin wrote:
>> Stefan,
>>
>> On 28.11.2016 16:01, Stefan Karlsson wrote:
>>> Hi Kirill,
>>>
>>> On 2016-11-25 20:55, Kirill Zhaldybin wrote:
>>>> Dear all,
>>>>
>>>> Could you please review this fix for 8166156?
>>>> Pretty straight-forward conversion.
>>>>
>>>> WebRev:
>>>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8166156/webrev.00/
>>>> CR: https://bugs.openjdk.java.net/browse/JDK-8166156
>>>
>>> Thanks for porting this test.
>>>
>>> I think it would be preferable if this test was using TEST instead of
>>> TEST_VM. I don't see anything in the test that requires the VM to run.
>> Thank you for noticing this.
>>
>> Here are a new WebRev:
>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8166156/webrev.01/
>>
>> Could you please let me know your opinion?
>>
>> Regards, Kirill
>>>
>>> Thanks,
>>> StefanK
>>>
>>>>
>>>> Thank you.
>>>>
>>>> Regards, Kirill
>>
More information about the hotspot-runtime-dev
mailing list