RFR: 8165526: Kitchensink sudden death - error code 0x406d1388

[Robbin Ehn]

Thanks George!

/Robbin


On 10/05/2016 04:58 PM, George Triantafillou wrote:
> +1
>
> -George
>
> On 10/5/2016 4:16 AM, David Holmes wrote:
>> Hi Robbin,
>>
>> This seems fine to me as it is the MSDN way of using this mechanism.
>>
>> https://msdn.microsoft.com/en-us/library/xcb2z8hs.aspx
>>
>> Thanks,
>> David
>>
>> On 5/10/2016 6:09 PM, Robbin Ehn wrote:
>>> Hi all, please review!
>>>
>>> We want to try the below work-around for this closed bug.
>>> The closed bug concerns same failure as in:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8079441
>>> Intermittent failures on Windows with "Unexpected exit from test [exit
>>> code: 1080890248]" (0x406d1388)
>>>
>>> EXCEPTION_CONTINUE_EXECUTION restarts at the same instruction which can
>>> be problematic.
>>> In this case we do not see any direct issue but still want to change it
>>> to EXCEPTION_EXECUTE_HANDLER.
>>>
>>> Thanks!
>>>
>>> /Robbin
>>>
>>> diff -r 4962f9f46728 src/os/windows/vm/os_windows.cpp
>>> --- a/src/os/windows/vm/os_windows.cpp    Mon Oct 03 21:48:21 2016 
>>> -0400
>>> +++ b/src/os/windows/vm/os_windows.cpp    Wed Oct 05 06:24:02 2016 
>>> +0100
>>> @@ -786,3 +790,3 @@
>>>      RaiseException (MS_VC_EXCEPTION, 0, sizeof(info)/sizeof(DWORD),
>>> (const ULONG_PTR*)&info );
>>> -  } __except(EXCEPTION_CONTINUE_EXECUTION) {}
>>> +  } __except(EXCEPTION_EXECUTE_HANDLER) {}
>>>  }
>