Review Request: JDK-8167511: IgnoreModulePropertiesTest.java needs update for JDK-8162401

[harold seigel]

Hi Mandy,

Sorry, I was off yesterday.  Your changes look good.

Harold


On 10/13/2016 7:40 AM, Lois Foltan wrote:
>
> On 10/11/2016 5:14 PM, Mandy Chung wrote:
>> Harold,
>>
>> Can you review this test update:
>>
>> diff --git a/test/runtime/modules/IgnoreModulePropertiesTest.java 
>> b/test/runtime/modules/IgnoreModulePropertiesTest.java
>> --- a/test/runtime/modules/IgnoreModulePropertiesTest.java
>> +++ b/test/runtime/modules/IgnoreModulePropertiesTest.java
>> @@ -69,8 +69,9 @@
>>       public static void main(String[] args) throws Exception {
>>           testOption("--add-modules", "java.sqlx", 
>> "jdk.module.addmods", "java.lang.module.ResolutionException");
>>           testOption("--limit-modules", "java.sqlx", 
>> "jdk.module.limitmods", "java.lang.module.ResolutionException");
>> -        testOption("--add-reads", "xyzz=yyzd", 
>> "jdk.module.addreads.0", "java.lang.RuntimeException");
>> -        testOption("--add-exports", "java.base/xyzz=yyzd", 
>> "jdk.module.addexports.0", "java.lang.RuntimeException");
>> +        testOption("--add-reads", "xyzz=yyzd", 
>> "jdk.module.addreads.0", "WARNING: Unknown module: xyzz");
>> +        testOption("--add-exports", "java.base/xyzz=yyzd", 
>> "jdk.module.addexports.0",
>> +                   "WARNING: package xyzz not in java.base");
>>           testOption("--patch-module", "=d", "jdk.module.patch.0", 
>> "IllegalArgumentException");
>>       }
>>   }
>
> Hi Mandy,
> Looks good.
>
>>
>> -—add-modules is now a repeating option.  Should this line:
>>    testOption("--add-modules", "java.sqlx", "jdk.module.addmods", 
>> "java.lang.module.ResolutionException");
>>
>> be changed to “jdk.module.addmods.0”, as in addreads, addexports 
>> property?
>
> Yes, I think it should.
> Lois
>
>>
>> Mandy
>