RFR: JDK-8157141 & JDK-8166454: Solaris getisax(2) and meminfo(2) cleanup

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Oct 19 17:43:50 UTC 2016


I missed all this review fun :)

Thank you, Alan, for cleaning this up.

The only concern I have is removal of conditional macros.

 > I've also taken the opportunity to strip out most of the '#ifndef(FOO)'
 > probes for the HW capability bit macros in vm_version_solaris_sparc.cpp.
 > They are now redundant as the macros are are in the system header files
 > from Solaris 11.1 onwards. The only ones that aren't are T7/M7 related
 > ones (from Solaris 11.3 onwards), namely AV_SPARC_FMAF and
 > AV2_SPARC_SPARC5. For those I've left the macro probes in place.

Most likely people will try to run JDK 9 on Solaris 10. Or in some kind 
of VM environment which may not have Solaris 11.1 headers. We have a lot 
such cases before that is why those macros were added.

"JDK 9 Platform Support" list only Solaris 11.x and 12.x. May be it is 
fine but original code would cover more running cases.

Sorry for rumbling.

Regards,
Vladimir

On 10/18/16 7:01 PM, David Holmes wrote:
> Pushed.
>
> David
>
> On 11/10/2016 11:12 AM, David Holmes wrote:
>> Ok. I will sponsor this once hs is open again.
>>
>> Thanks,
>> David
>>
>> On 6/10/2016 10:10 PM, Alan Burlison wrote:
>>> On 04/10/2016 19:37, Alan Burlison wrote:
>>>
>>>>> It’s in globalDefinitions.hpp, on the off chance that’s somehow not
>>>>> already being included.
>>>>
>>>> Cool, I'll pop that in instead - thanks!
>>>
>>> Done, webrev updated, jprt hotspot testset is clean.
>>>


More information about the hotspot-runtime-dev mailing list