RFR(s): 8165215: Setting same UL tag multiple times matches wrong tagset

Robbin Ehn robbin.ehn at oracle.com
Thu Sep 1 16:27:48 UTC 2016


Hi Marcus,

On 09/01/2016 01:08 PM, Marcus Larsson wrote:
> Hi Robbin,
>
>
> On 09/01/2016 09:55 AM, Robbin Ehn wrote:
>> Hi all, please review this bug fix.
>>
>> Webrev: http://cr.openjdk.java.net/~rehn/8165215/webrev/
>
> I have one nit:
>
> Perhaps we could improve the error message to something like:
>
> errstream->print_cr("Duplicate tag '%s' in tag combination: %s", cur_tag, cur)
>

I'll change the message to above before push.

Thanks!

/Robbin

>
> Otherwise this looks good! Thanks for fixing this.
>
> Thanks,
> Marcus
>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8165215
>>
>> Test with gtest.
>>
>> Thanks!
>>
>> /Robbin
>


More information about the hotspot-runtime-dev mailing list